ui: fix namespace url filter#2970
Open
egabancho wants to merge 1 commit intoinveniosoftware:masterfrom
Open
Conversation
Member
egabancho
commented
Jan 28, 2025
egabancho
commented
- The filter was failing with and IndexError when trying to parse fields with no namespace.
Contributor
|
This PR was automatically marked as stale. |
max-moser
reviewed
Mar 31, 2026
| if not namespaces.get(namespace): | ||
| return None | ||
|
|
||
| namespace_value = namespace_array[1] |
Contributor
There was a problem hiding this comment.
If I understand correctly, then this move avoids the array index access for fields that don't have a namespace (i.e. no : in their name)?
Could it be that a field name happens to collide with a namespace name, still causing this to fail?
E.g. having a namespace test (as in the tests below), and a field with the name test?
This would satisfy the check if {"test": ...}.get("test"), still causing this out of bounds error?
egabancho
force-pushed
the
filter-non-namespaced-custom-fields
branch
3 times, most recently
from
991675c to
80fabe7
Compare
* The filter was failing with and IndexError when trying to parse fields with no namespace.
egabancho
force-pushed
the
filter-non-namespaced-custom-fields
branch
from
80fabe7 to
f948a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.