Skip to content

config: compat with new VCS integration#3162

Merged
zzacharo merged 1 commit intoinveniosoftware:masterfrom
palkerecsenyi:vcs
Apr 2, 2026
Merged

config: compat with new VCS integration#3162
zzacharo merged 1 commit intoinveniosoftware:masterfrom
palkerecsenyi:vcs

Conversation

@palkerecsenyi
Copy link
Copy Markdown
Member

@palkerecsenyi palkerecsenyi commented Aug 19, 2025

Closes inveniosoftware/invenio-vcs#2


@palkerecsenyi palkerecsenyi force-pushed the vcs branch 2 times, most recently from 970f79c to a80d05f Compare October 15, 2025 14:33
@palkerecsenyi palkerecsenyi marked this pull request as ready for review October 16, 2025 09:51
@palkerecsenyi
Copy link
Copy Markdown
Member Author

Tests are currently failing due to a dependency issue which we need to fix.

We are importing and referencing RDMVCSRelease in the config. Currently this is failing as the invenio-vcs has not been published. However, we now want this to be an optional dependency rather than a default one (as it currently is in invenio-rdm-records, with the plugin being enabled through the GITHUB_INTEGRATION_ENABLED flag instead of the mere presence of the dependency). So we need to find a way to only apply the release class override if the user has manually installed the dependency and not to crash otherwise.

Copy link
Copy Markdown
Contributor

@carlinmack carlinmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, from Carlin and Maira

@carlinmack
Copy link
Copy Markdown
Contributor

maybe you can squash? I feel like this is 1 commit's worth of stuff in the end

@palkerecsenyi
Copy link
Copy Markdown
Member Author

@carlinmack Yes my aim is definitely to squash into one, same for inveniosoftware/invenio-rdm-records#2128. We're currently merging the PRs in Invenio VCS and then I will squash these 2 PRs since they will probably still have quite a few changes before we start reviewing them.

@palkerecsenyi palkerecsenyi force-pushed the vcs branch 4 times, most recently from 9d3d7a8 to e8e162d Compare April 1, 2026 13:59
@zzacharo zzacharo merged commit e55c6b8 into inveniosoftware:master Apr 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make invenio-github support other VCS providers

5 participants