fix: using app locale for citations #3322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samk13
approved these changes
Feb 6, 2026
Member
Samk13
left a comment
Samk13
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for this!
Using the UI language as a fallback while keeping the more specific browser locale when it matches makes the behavior more predictable.
Comment on lines
61
to
63
| const citationLocale = navigator.language.startsWith(i18next.language) | ||
| ? navigator.language | ||
| : i18next.language; |
Member
There was a problem hiding this comment.
Suggested change
| const citationLocale = navigator.language.startsWith(i18next.language) | |
| ? navigator.language | |
| : i18next.language; | |
| const navLang = (navigator.language || "").toLowerCase(); | |
| const uiLang = (i18next.language || "").toLowerCase(); | |
| const citationLocale = | |
| uiLang && navLang.startsWith(uiLang) | |
| ? navigator.language | |
| : i18next.language || navigator.language; |
Would it make sense to normalize casing and add a fallback here to avoid en-US vs en-us mismatches and prevent locale=undefined if i18next.language isn’t set yet, while keeping the same behavior otherwise?
Author
There was a problem hiding this comment.
@Samk13 Thanks for the feedback, generally, I've never had issue with missing values in context of i18next or navigator, but your suggestion is more defensive, so I've modified it like you proposed. Regards
* app was using navigator.language which is always * browser setting. The change enables using localization * based on app settings and using translated strigns that exist in * citeproc library
Ducica
force-pushed
the
oarepo-contribution-citation-localization-based-on-app-locale
branch
from
858532e to
548d5b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the citation is always generated based on browser selected locale. This change uses language selected in the app. Normally, in invenio you only have access to language code, so if the language setting in the browser starts with this language code it sends the entire locale i.e. en_GB, if not, it only sends en. The citeproc library has good behavior, even in case only language code is provided.
Before:
After:
Noter that benefit depens on the citation style i.e. some styles that contain more text, other than record data benefit more.
Please let us know what you think.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: