Skip to content

Conversation

@mairasalazar
Copy link

@mairasalazar mairasalazar commented Feb 6, 2026

❤️ Thank you for your contribution!

Description

  • Ensures the accordion icons for parent facets are displayed in full after the change
    in inveniosoftware/invenio-search-ui@e4c83db, by using the preset variables from Semantic UI.
  • Adjust padding to better convey parent-child relationship visually.

Before
image

After
image

Closes #3178

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

* The accordion icons were not being displayed in full after the change
in
inveniosoftware/invenio-search-ui@e4c83db
* Fixes that by using the preset variables from Semantic UI instead
of setting the height and width of the arrow icon to auto.

Closes inveniosoftware#3178
* The children facets indentation was too small compared to the
parents, and too far vertically from them.
* Adjust padding to better convey parent-child relationship visually.

Closes inveniosoftware#3178
Copy link
Contributor

@carlinmack carlinmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :) Could you add a before/after image to the description?

@mairasalazar mairasalazar self-assigned this Feb 9, 2026
@mairasalazar mairasalazar moved this to In progress in Sprint Q1/2026 Feb 9, 2026
@mairasalazar mairasalazar removed their assignment Feb 9, 2026
@mairasalazar mairasalazar moved this to In review 🔍 in Sprint Q1/2026 Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

search-ui: misaligned nested facet items

2 participants