Skip to content

feat(models): use UUIDv7 for AuditLog.id #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slint wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(models): use UUIDv7 for AuditLog.id #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion invenio_audit_logs/records/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,15 @@

"""Base model classes for Audit Logs in Invenio."""


from invenio_db import db
from invenio_records.models import RecordMetadataBase
from sqlalchemy.types import String
from sqlalchemy_utils.types import UUIDType

try:
from uuid import uuid7
Copy link
Copy Markdown
Contributor

@utnapischtim utnapischtim Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the official start of bringing in python3.14 features?

Copy link
Copy Markdown
Member Author

@slint slint Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, more of a forwards compatibility measure.

Though lots of folks are eager to go all the way to 3.14, given some recent performance comparisons 😉

except ImportError:
from uuid_utils.compat import uuid7


class AuditLog(db.Model, RecordMetadataBase):
Expand All @@ -20,6 +25,12 @@ class AuditLog(db.Model, RecordMetadataBase):

encoder = None

id = db.Column(
UUIDType,
primary_key=True,
default=uuid7,
)

action = db.Column(String(255), nullable=False)

resource_type = db.Column(String(255), nullable=False)
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ install_requires =
invenio-records-resources>=8.0.0,<9.0.0
invenio-administration>=4.0.0,<5.0.0
invenio-accounts>=6.0.0,<7.0.0
uuid-utils>=0.11.1; python_version < '3.14'

[options.extras_require]
tests =
Expand Down
Loading