administration: fix UI#1274
Merged
kpsherva merged 1 commit intoinveniosoftware:masterfrom Feb 10, 2025
Merged
Conversation
anikachurilova
commented
Feb 10, 2025
| <Element | ||
| key={actionKey} | ||
| onClick={this.onModalTriggerClick} | ||
| onClick={(e, data) => this.onModalTriggerClick(e, { ...data, actionConfig: actionConfig })} |
Member
Author
There was a problem hiding this comment.
Feature button was braking the UI, because actionConfig had to be passed in ActionForm in line 66
anikachurilova
force-pushed
the
harvester-reader
branch
from
22c0e69 to
97b8ee0
Compare
anikachurilova
force-pushed
the
harvester-reader
branch
from
97b8ee0 to
a306450
Compare
anikachurilova
commented
Feb 10, 2025
| from invenio_records_resources.services.records.config import RecordServiceConfig | ||
| from invenio_records_resources.services.records.config import ( | ||
| RecordServiceConfig, | ||
| ) |
Member
Author
There was a problem hiding this comment.
isort was failing 🤷♀️
Member
There was a problem hiding this comment.
FYI, there is an issue with the newest isort release PyCQA/isort#2352
kpsherva
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make consistent with the changes in inveniosoftware/invenio-administration#234
