Fix-axios-version

[Samk13]

❤️ Thank you for your contribution!

Description

related to inveniosoftware/invenio-search-ui#215

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[Samk13]

Dependency resolution is failing on CI, while it works locally. I’ve tried various lower bounds combinations without success, e.g.:

install_requires =
    invenio-oaiserver>=2.4.0,<3.0.0
    invenio-requests>=4.1.0,<5.0.0
    invenio-search-ui>=2.9.0,<3.0.0
    invenio-vocabularies>=3.5.0,<4.0.0
    invenio-administration>=2.2.4,<3.0.0

[options.extras_require]
tests =
    pytest-black-ng>=0.4.0
    Faker>=2.0.3
    invenio-app>=1.5.1,<2.0.0
    invenio-db[postgresql,mysql]>=1.3.1,<2.0.0
    pytest-invenio>=2.2.1,<3.0.0
    sphinx>=4.5.0
opensearch1 =
    invenio-search[opensearch1]>=2.4.1,<3.0.0
opensearch2 =
    invenio-search[opensearch2]>=2.4.1,<3.0.0

[utnapischtim]

invenio-search-ui needs to be >=2.4.0, otherwise it conflicts with app-rdm

[Samk13]

We can try that.

[Samk13]

I tried all the ways here: https://pip.pypa.io/en/latest/topics/dependency-resolution/#reduce-the-number-of-versions-pip-is-trying-to-use but it looks like Any compatible version. syntax works!

[tmorrell]

Since this is needed to fix broken v12 installs.

[fenekku]

Have you tried adding invenio-records-resources>=5.10.0,<6.0.0 to that list? (something I am adding here #1294 ) It's directly used and makes sense to surface up one level.

[Samk13]

Are we using this maint-v2.2.x branch?
https://github.com/inveniosoftware/invenio-administration/tree/maint-v2.2.x
it's confusing to have it there along with maint-v2.x, can we safely remove it?

[Samk13]

reason why I am asking is when I check locally what version is been resolved its invenio-administration==2.2.4 while what we have latest on 2 is 2.11.0
could be the the resolver getting confused here? even though it should be looking for tag number when resolving.
I checked where administration is pinned in other packages but didn't find any. this is the last place to look for.

vocabularies
administration is not required here at this version, the newer tags is:
https://github.com/inveniosoftware/invenio-vocabularies/blob/v3.5.0/setup.cfg

pages:
https://github.com/inveniosoftware/invenio-pages/blob/v4.1.2/setup.cfg#L42

Users-resources
https://github.com/inveniosoftware/invenio-users-resources/blob/maint-v6.x/setup.cfg#L30

banners
https://github.com/inveniosoftware/invenio-banners/blob/v3.3.1/setup.cfg#L30

communities:
https://github.com/inveniosoftware/invenio-communities/blob/v13.1.0/setup.cfg#L34

rdm-records:
https://github.com/inveniosoftware/invenio-rdm-records/blob/v10.9.2/setup.cfg#L42

[Samk13]

Have you tried adding invenio-records-resources>=5.10.0,<6.0.0 to that list? (something I am adding here #1294 ) It's directly used and makes sense to surface up one level.

and it did not resolve:

The conflict is caused by:
    invenio-administration 2.0.0 depends on invenio-accounts<5.0.0 and >=4.0.0
    invenio-records-resources 5.11.1 depends on invenio-accounts<6.0.0 and >=5.0.0
    invenio-records-resources 5.10.1 depends on invenio-accounts<6.0.0 and >=5.0.0
    invenio-records-resources 5.10.0 depends on invenio-accounts<6.0.0 and >=5.0.0

[Samk13]

Changing to administration to ~=2.2.4 resolves.
and now it works without ~=🪄

invenio-oaiserver>=2.2.0,<3.0.0
invenio-requests>=4.0.0,<5.0.0
invenio-search-ui>=2.4.0,<3.0.0
invenio-vocabularies>=3.0.0,<4.0.0
invenio-administration>=2.0.0,<3.0.0
invenio-records-resources>=5.10.0,<6.0.0 # <-- the magic line

[fenekku]

If tests pass again LGTM

[Samk13]

If tests pass again LGTM

After merging this one, if any new issues arise, we’ll know exactly which PR to blame 😅