fix: rename variable

[utnapischtim]

• the variable name in communities_requests is community and not
  community_ui

[ntarocco]

Having the 2 vars with the same value is not super great. They have different purposes, see for example here.
I would suggest changing instead:

• the current var in the previous line, which is clearly wrongly named:

- community=community_ui,
+ community_ui=community_ui,

• its usage in the template here

WDYT?

[utnapischtim]

the reason why i did the quick fix and add another variable with the same name and value was because i couldn't understand where community is used. since the refactor commit 9909924 introduced that bug, i thought it is safer to not remove community=community_ui

[utnapischtim]

so to be safe, all community variables would have to be renamed to community_ui in the context of invenio_communities/views/communities.py and the then used jinja templates?

[ntarocco]

the reason why i did the quick fix and add another variable with the same name and value was because i couldn't understand where community is used. since the refactor commit 9909924 introduced that bug, i thought it is safer to not remove community=community_ui

It should be in the view's template (I linked it above).

so to be safe, all community variables would have to be renamed to community_ui in the context of invenio_communities/views/communities.py and the then used jinja templates?

Only the ones that have value community_ui -> community=community_ui. Basically, community is the obj, and community_ui it serialized version, they are different. We should keep naming consistent to mark the difference.

[utnapischtim]

Only the ones that have value community_ui -> community=community_ui. Basically, community is the obj, and community_ui it serialized version, they are different. We should keep naming consistent to mark the difference.

i think that doesn't work either without putting more thinking and testing time into it. for communities_subcommunities community is used here and here. can i replace that with community_ui["metadata"]["title"] and community_ui["slug"]?

btw this is also a problem here

so it could be that i need community=community and community_ui=community_ui, or i refactor the usage of community.metadata etc completly

[ntarocco]

For the time being, fine by me adding both:

community=community
community_ui=community_ui

☺️