Skip to content

Conversation

@Samk13
Copy link
Member

@Samk13 Samk13 commented Jul 7, 2025

❤️ Thank you for your contribution!

Description

  • Remove React as a dev dependency in translations package.json
  • Move React and React-Dom to PeerDependency instead of dev

More deps could be moved to peerDeps if this is approved.

This is part of the fix for the blank screen in the dev environment issue; see:
inveniosoftware/invenio-app-rdm#3048

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Samk13 added 2 commits July 7, 2025 17:51
* remove unnecessary react dependency from translations
  package.json
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale label Sep 6, 2025
@utnapischtim utnapischtim moved this to 👀 In review in vNext Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

1 participant