(fix)lift embargo: removing pid reserving #2137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removing the manager method as it does not change anything (if DOI was not already on the record, it won't be created here)
ptamarit
reviewed
Sep 5, 2025
| self._pids.pid_manager.create_and_reserve(record) | ||
| uow.register(RecordCommitOp(record, indexer=self.indexer)) | ||
| uow.register(TaskOp(register_or_update_pid, record["id"], "doi", parent=False)) | ||
| # If the record was previously public it will still keep the parent PID |
Member
There was a problem hiding this comment.
Should the parent PID logic also be removed?
ptamarit
reviewed
Sep 5, 2025
| "lift_embargo", identity, draft=draft, record=record, uow=uow | ||
| ) | ||
|
|
||
| self._pids.pid_manager.create_and_reserve(record) |
Member
There was a problem hiding this comment.
This is breaking one unit test.
Contributor
|
This PR was automatically marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.