Skip to content

Conversation

@mesemus
Copy link
Contributor

@mesemus mesemus commented Dec 20, 2025

Description

  • recent update in idutils started normalizing wikidata identifier
  • tests here were using fake value and thus started failing
  • using real CERN's identifier fixes the test

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@mesemus mesemus force-pushed the fix-wikidata-identifier branch 2 times, most recently from 1ed58bc to ee0ffeb Compare December 20, 2025 19:17
* recent update in idutils started
   normalizing wikidata identifier
* using fake value in tests caused
  normalization to fail
* using real CERN's identifier fixes the test
@mesemus mesemus force-pushed the fix-wikidata-identifier branch from ee0ffeb to a9f0c8c Compare January 13, 2026 13:25
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I think there were just missed in previous PR.

@tmorrell
Copy link
Contributor

Closing and reopening for CI purposes. I'll merge tomorrow unless there is some objection.

@tmorrell tmorrell closed this Jan 13, 2026
@tmorrell tmorrell reopened this Jan 13, 2026
@tmorrell tmorrell merged commit dca3120 into inveniosoftware:master Jan 14, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants