fix: handle multipart uploads with >1000 parts for AWS/RadosGW#42
Merged
egabancho merged 1 commit intoinveniosoftware:masterfrom Aug 5, 2025
Merged
Conversation
79f94a0 to
10fe04c
Compare
* For very large files (hundreds of GB), multipart uploads in the current UI uploader can exceed 1000 parts * Unlike MinIO, AWS and RadosGW part listings return at most 1000 parts per response. Code now handles pagination to retrieve all parts * Added manual test to verify the fix (disabled by default). MinIO's implementation differs by returning full listings unconditionally and cannot be used to test the fix. → See test_multipart.py for manual test execution details
10fe04c to
99d7497
Compare
wgresshoff
approved these changes
Aug 4, 2025
Contributor
wgresshoff
left a comment
There was a problem hiding this comment.
This looks very good to me, great you added a test for >parts as well!
egabancho
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes failing multipart upload for very large files to AWS or RadosGW.
1000 parts
now handles pagination to retrieve all parts
returning full listings unconditionally and cannot be used to test the fix.
→ See test_multipart.py for manual test execution details
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: