Skip to content

Improve handling of 'self checkout' action in backoffice loan page #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpsherva merged 2 commits into from
Sep 17, 2025
Merged

Improve handling of 'self checkout' action in backoffice loan page #659

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ea7dc0
backoffice: fix: omit option to self_checkout on loan with no items
JakobMiesner Aug 26, 2025
0646ebd
backoffice: loan: ui: change formatting of text on the action buttons
JakobMiesner Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/pages/backoffice/Loan/LoanDetails/LoanActions/LoanActions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ import { ExtendModal } from '@pages/backoffice/Loan/LoanDetails/LoanActions/Exte
import { CancelLoanModal } from './CancelButton';
import { omit } from 'lodash/object';
import _isEmpty from 'lodash/isEmpty';
import capitalize from 'lodash/capitalize';
import startCase from 'lodash/startCase';

export default class LoanActions extends Component {
renderAvailableActions(pid, patronPid, documentPid, itemPid, actions = {}) {
const { performLoanAction, isLoading, loanDetails } = this.props;

// omit checkout because it must done in one of the available items
if (!itemPid) {
actions = omit(actions, 'checkout');
actions = omit(actions, ['checkout', 'self_checkout']);
}

return Object.keys(actions).map((action) => {
Expand Down Expand Up @@ -49,7 +49,7 @@ export default class LoanActions extends Component {
loading={isLoading}
disabled={isLoading}
>
{capitalize(action)}
{startCase(action)}
</Button>
)}
</List.Item>
Expand Down
Loading