add(tab titles): added unique tab titles for each page in frontoffice - #715
Open
callumlewis05 wants to merge 2 commits into
Open
add(tab titles): added unique tab titles for each page in frontoffice#715callumlewis05 wants to merge 2 commits into
callumlewis05 wants to merge 2 commits into
Conversation
callumlewis05
force-pushed
the
tab-title
branch
from
August 7, 2026 14:35
50a7881 to
24ad286
Compare
callumlewis05
marked this pull request as ready for review
August 12, 2026 15:14
callumlewis05
force-pushed
the
tab-title
branch
2 times, most recently
from
August 14, 2026 15:10
0478714 to
4c01f2d
Compare
callumlewis05
force-pushed
the
tab-title
branch
from
August 14, 2026 15:16
4c01f2d to
02ca7ee
Compare
kpsherva
reviewed
Aug 25, 2026
| "node": ">=22.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "react-helmet-async": "^3.0.0" |
Contributor
There was a problem hiding this comment.
for this library - did you consider any other alternatives? Could you summarise? It is slightly concerning that the library has a single contributor, plus it is already forked from elsewhere, I am worried about future maintainability
Contributor
Author
There was a problem hiding this comment.
At the time I looked at other ways of doing it and I found there is a way of doing it in plain JS but I remember it was more complex and I believe there were other suitable libraries but this was the best with the most recent updates and most used. If you think it is worth it for one less dependency I can change it to plain JS?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gave each page in the front and back office a unique title to help easily identify them whilst many tabs are open.