fix: more consistent props across fields #296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added the `disabled` and `required` props to `SubjectAutocompleteDropdown`, `SelectField`, `TextField`, `RichInputField` * Moved the `helpText` to be shown above `ArrayField` rather than below it for a neater appearance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes inveniosoftware/invenio-app-rdm#3103
Please release at the same time as inveniosoftware/invenio-rdm-records#2101 and #298
❤️ Thank you for your contribution!
Description
This PR contains some changes that will help make overriding deposit form fields more predictable and consistent once inveniosoftware/invenio-rdm-records#2101 is also merged.
Added the
disabledandrequiredprops toSubjectAutocompleteDropdown,SelectField,TextField,RichInputFieldMoved the
helpTextto be shown aboveArrayFieldrather than below it for a neater appearance (this was already the behaviour in some fields of the deposit form, where a custom help text component was being added instead of simply using the prop, for example inRelatedWorksField). See the examples below:See examples
Already existing manual helptext component:
New helptext added via prop:
Added support for
helpTextto theSelectFieldSee example