-
Notifications
You must be signed in to change notification settings - Fork 30
overridable: add dynamicParametrize function #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
palkerecsenyi
wants to merge
4
commits into
inveniosoftware:master
Choose a base branch
from
palkerecsenyi:dynamic-parametrize
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
overridable: add dynamicParametrize function #300
palkerecsenyi
wants to merge
4
commits into
inveniosoftware:master
from
palkerecsenyi:dynamic-parametrize
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a function to 'dynamically' parametrize a component, based on values from the context. Currently, this includes the field values stored in Formik, but we can easily add more values from the React context as needed. * The user can implement a function that receives these input values and returns the override props for a given `Overridable` component. They need to import the `dynamicParametrize` function from the top level of this module, as well as the component they want to override. * `dynamicParametrize` might currently throw an error if used on a component that's rendered outside of the Formik context
510174d
to
ddecc4e
Compare
ddecc4e
to
7c7a975
Compare
* If the user wants to base their dynamic prop override on some existing prop values (e.g. filtering the options of a dropdown according to the value of another field), it is significantly easier for them if these values are available through the `propsFactory` function
zzacharo
approved these changes
Jul 25, 2025
8ff4535
to
17950c2
Compare
sakshamarora1
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #299
Note: may cause conflicts when merging at the same time as #298, I am happy to resolve these whenever we are ready.
Description
Added a function to 'dynamically' parametrize a component, based on values from the context. Currently, this includes the field values stored in Formik, but we can easily add more values from the React context as needed.
The user can implement a function that receives these input values and returns the override props for a given
Overridable
component. They need to import thedynamicParametrize
function from the top level of this module, as well as the component they want to override.dynamicParametrize
might currently throw an error if used on a component that's rendered outside of the Formik contextUsage example
Kooha-2025-07-17-15-42-47.webm