Skip to content

Conversation

@matmair
Copy link
Contributor

@matmair matmair commented Nov 10, 2025

Improve MFA experience when MFA enforcement gets enabled.

  • All users are logged out when mfa enforcement is changed
  • There is an explanation os-level alert before that happens
  • The mandatory MFA registration now works on new logins
  • Fix single-form login with password managers

Closes #10754
Closes #11122

@matmair matmair self-assigned this Nov 10, 2025
@matmair matmair added setup Relates to the InvenTree setup / installation process User Interface Related to the frontend / User Interface labels Nov 10, 2025
@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit d83deab
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/69682dcf30d30700071e8ff0

@matmair matmair added this to the 1.2.0 milestone Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.11%. Comparing base (07e1a72) to head (d83deab).
⚠️ Report is 1 commits behind head on master.

❌ Your patch status has failed because the patch coverage (91.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10796      +/-   ##
==========================================
- Coverage   88.17%   88.11%   -0.07%     
==========================================
  Files        1290     1290              
  Lines       58203    58273      +70     
  Branches     1969     1968       -1     
==========================================
+ Hits        51319    51345      +26     
- Misses       6393     6437      +44     
  Partials      491      491              
Flag Coverage Δ
backend 89.46% <91.89%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 92.01% <ø> (ø)
Backend General 93.49% <91.66%> (-0.03%) ⬇️
Frontend 70.83% <ø> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing matmair:fix_mfa_enforce_sessions (d83deab) with master (07e1a72)

Summary

✅ 44 untouched benchmarks
⏩ 29 skipped benchmarks1

Footnotes

  1. 29 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@matmair matmair changed the title fix: mfa enforce fix: MFA enforce flows / interactions Jan 15, 2026
@matmair
Copy link
Contributor Author

matmair commented Jan 15, 2026

@SchrodingersGat ready for review and maybe also a trial. I have spent a lot of time testing this, but maybe I have overseen some edge case.

@matmair matmair marked this pull request as ready for review January 15, 2026 00:38
@SchrodingersGat
Copy link
Member

@matmair nice work, looks good from my testing. Thanks for fixing this!

@SchrodingersGat SchrodingersGat merged commit 9fa40ae into inventree:master Jan 15, 2026
36 of 37 checks passed
@SchrodingersGat SchrodingersGat deleted the fix_mfa_enforce_sessions branch January 15, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

setup Relates to the InvenTree setup / installation process User Interface Related to the frontend / User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"You must enable two-factor authentication before doing anything else.", while trying to enable 2fa MFA Issues

2 participants