-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[API] Filter refactor #11073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SchrodingersGat
wants to merge
41
commits into
inventree:master
Choose a base branch
from
SchrodingersGat:filter-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,228
−927
Open
[API] Filter refactor #11073
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
21e4370
Lazy evaluation of optional serializer fields
SchrodingersGat 5a166f8
Refactor BuildLineSerializer class
SchrodingersGat f798307
Simplify gathering
SchrodingersGat b397ab9
Refactor BuildSerializer
SchrodingersGat 09d35d2
Refactor other Build serializers
SchrodingersGat 8f47288
Refactor Part serializers
SchrodingersGat 70489cd
Refactoring more serializers to use OptionalField
SchrodingersGat 25dd239
More refactoring
SchrodingersGat e71268a
Cleanup for mixin class
SchrodingersGat 34a7474
Ensure any optional fields we added in are not missed
SchrodingersGat dcf6a55
Fixes
SchrodingersGat 31c21a5
Rehydrate optional fields for metadata
SchrodingersGat b62a89a
Add TreePathSerializer class
SchrodingersGat fc6bb24
Further improvements:
SchrodingersGat 6ad980a
Adjust unit tests
SchrodingersGat 9e46356
Fix for "build_relational_field"
SchrodingersGat cddf922
Fix case where multiple fields can share same filter
SchrodingersGat 61251f4
additional unit tests
SchrodingersGat 0386a6a
Bump API version
SchrodingersGat b18a3e3
Remove top-level detection
SchrodingersGat ea049ab
Cache serializer to prevent multiple __init__ calls
SchrodingersGat 4785f79
Revert caching change
SchrodingersGat 7123efc
Simplify field removal
SchrodingersGat 95e0aa8
Adjust unit test
SchrodingersGat a18dffe
Remove docstring comment which is no longer true
SchrodingersGat 30f7760
Merge branch 'master' into filter-refactor
SchrodingersGat cae2644
Ensure read-only fields are skipped for data import
SchrodingersGat 8e77006
Use SAFE_METHODS
SchrodingersGat 853726e
Do not convert to lowercase
SchrodingersGat 61afb97
Updated docstring
SchrodingersGat fa3f080
Remove FilterableSerializerField mixin
SchrodingersGat 4bbd3dd
Merge branch 'master' into filter-refactor
SchrodingersGat 4244367
Ensure all fields are returned when generating schema
SchrodingersGat eb8ce92
Fix order of operations
SchrodingersGat f8cab0e
Merge branch 'master' into filter-refactor
matmair 3793a75
Merge commit 'e1b5fbd38da3b6e7e96272532278fa9f52da5e69' into filter-r…
SchrodingersGat d07a77d
Add assertion to unit test
SchrodingersGat e84b50e
Merge branch 'master' into filter-refactor
matmair e688e4c
Merge branch 'master' into filter-refactor
matmair 65b944e
Merge branch 'master' into filter-refactor
matmair e75ebd4
Merge branch 'master' into filter-refactor
SchrodingersGat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be other API changes too, should they also be mentioned?