Skip to content

Conversation

@jacobfelknor
Copy link
Contributor

@jacobfelknor jacobfelknor commented Aug 15, 2025

fixes #274

Make pip-system-certs an optional dependency, allowing the user to tune the install to fit their environment

@SchrodingersGat
Copy link
Member

@jacobfelknor is this all that is required? No code changes?

@jacobfelknor
Copy link
Contributor Author

jacobfelknor commented Aug 15, 2025

To my understanding, yes. I think all this package does is configure Python to use the OS certificate store rather than it's own bundled store.

I could really only see using the system store being helpful if your InvenTree instance used a certificate signed by an internal CA, which can be common in an enterprise setting. I don't need this and it actually was causing problems for me.

@matmair may be able to clarify further if my understanding is incorrect.

@SchrodingersGat SchrodingersGat merged commit c04599a into inventree:master Aug 16, 2025
4 checks passed
@SchrodingersGat
Copy link
Member

@jacobfelknor thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pip-system-certs dependency

2 participants