Skip to content

Conversation

@notaphplover
Copy link
Member

Description

  • Added GetAllOptions type.
  • Updated container.getAll with optional GetAllOptions param.
  • Updated container.getAllAsync with optional GetAllOptions param.

Related Issue

#1670

Motivation and Context

container.getAll behavior is fairly confusing. Users might be interested in enabling binding constraints in the root level of a plan. GetAllOptions is introduced to provide such a behavior without reaking the exisitng one.

How Has This Been Tested?

  • Tests have been added to cover whis scenario.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (59aac5c) to head (ecaeaae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1671   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          52       52           
  Lines        1332     1333    +1     
  Branches      180      181    +1     
=======================================
+ Hits         1320     1321    +1     
  Misses         11       11           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notaphplover notaphplover merged commit 30314de into master Dec 4, 2024
6 checks passed
@notaphplover notaphplover deleted the feat/update-container-get-all-with-options branch December 4, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants