feat: add config severities tests

Author: Artur-Wisniewski

packages/custom_lint_builder/test/analyzer_converter_test.dart

@@ -83,4 +83,72 @@ void main() {
       },
     );
   });
+
+  test('Respects configSeverities when converting errors', () {
+    final resourceProvider = MemoryResourceProvider();
+    final source = FileSource(
+      resourceProvider.newFile(
+        '/home/user/project/lib/main.dart',
+        'void main() {}',
+      ),
+    );
+
+    // Create an analysis error with INFO severity
+    final error = AnalysisError.tmp(
+      source: source,
+      offset: 0,
+      length: 4,
+      errorCode: const LintCode(
+        name: 'rule_name_1',
+        problemMessage: 'This is a lint',
+      ),
+    );
+
+    // Create config severities map that changes rule_name_1 to ERROR
+    final configSeverities = <String, ErrorSeverity>{
+      'rule_name_1': ErrorSeverity.ERROR,
+      'rule_name_2': ErrorSeverity.WARNING,
+    };
+
+    final converter = CustomAnalyzerConverter();
+
+    // Convert the error without config severities - should be INFO
+    final defaultResult = converter.convertAnalysisError(error);
+    expect(defaultResult.severity.name, 'INFO');
+
+    // Convert the error with direct severity override
+    final withSeverityParam = converter.convertAnalysisError(
+      error,
+      severity: ErrorSeverity.ERROR,
+    );
+    expect(withSeverityParam.severity.name, 'ERROR');
+
+    // Convert the error with config severities through convertAnalysisErrors
+    final withConfigSeverities = converter.convertAnalysisErrors(
+      [error],
+      configSeverities: configSeverities,
+    ).single;
+
+    // Config severities should have overridden the default severity
+    expect(withConfigSeverities.severity.name, 'ERROR');
+
+    // Create an error with a rule name that doesn't have a config severity
+    final errorWithoutConfigSeverity = AnalysisError.tmp(
+      source: source,
+      offset: 0,
+      length: 4,
+      errorCode: const LintCode(
+        name: 'no_config_rule',
+        problemMessage: 'This is another lint',
+      ),
+    );
+
+    final noConfigResult = converter.convertAnalysisErrors(
+      [errorWithoutConfigSeverity],
+      configSeverities: configSeverities,
+    ).single;
+
+    // Should use default severity when not in config
+    expect(noConfigResult.severity.name, 'INFO');
+  });
 }

packages/custom_lint_core/test/configs_test.dart

@@ -1,6 +1,7 @@
 import 'dart:convert';
 import 'dart:io' as io;
 
+import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:custom_lint_core/custom_lint_core.dart';
@@ -115,6 +116,7 @@ custom_lint:
   test('Empty config', () {
     expect(CustomLintConfigs.empty.enableAllLintRules, null);
     expect(CustomLintConfigs.empty.rules, isEmpty);
+    expect(CustomLintConfigs.empty.errors, isEmpty);
   });
 
   group('parse', () {
@@ -188,6 +190,25 @@ custom_lint:
       );
     });
 
+    test('has an immutable map of errors', () {
+      final analysisOptions = createAnalysisOptions('''
+custom_lint:
+  errors:
+    a: error
+''');
+      final configs = CustomLintConfigs.parse(analysisOptions, packageConfig);
+
+      expect(
+        configs.errors,
+        {'a': ErrorSeverity.ERROR},
+      );
+
+      expect(
+        () => configs.errors['a'] = ErrorSeverity.INFO,
+        throwsUnsupportedError,
+      );
+    });
+
     test(
         'if custom_lint is present and defines some properties, merges with "include"',
         () {
@@ -338,6 +359,68 @@ foo:
       });
     });
 
+    test('Parses error severities from configs', () {
+      final analysisOptions = createAnalysisOptions('''
+custom_lint:
+  errors:
+    rule_name_1: error
+    rule_name_2: warning
+    rule_name_3: info
+    rule_name_4: none
+''');
+      final configs = CustomLintConfigs.parse(analysisOptions, packageConfig);
+
+      expect(configs.errors, {
+        'rule_name_1': ErrorSeverity.ERROR,
+        'rule_name_2': ErrorSeverity.WARNING,
+        'rule_name_3': ErrorSeverity.INFO,
+        'rule_name_4': ErrorSeverity.NONE,
+      });
+    });
+
+    test('Handles unknown error severity values', () {
+      final analysisOptions = createAnalysisOptions('''
+custom_lint:
+  errors:
+    rule_name_1: invalid_severity
+''');
+      expect(
+        () => CustomLintConfigs.parse(analysisOptions, packageConfig),
+        throwsA(
+          isArgumentError.having(
+            (e) => e.message,
+            'message',
+            'Provided error severity: invalid_severity specified for key: rule_name_1 is not valid. '
+                'Valid error severities are: none, info, warning, error',
+          ),
+        ),
+      );
+    });
+
+    test('Merges error severities from included config file', () {
+      final includedFile = createAnalysisOptions('''
+custom_lint:
+  errors:
+    rule_name_1: error
+    rule_name_2: warning
+''');
+
+      final analysisOptions = createAnalysisOptions('''
+include: ${includedFile.path}
+custom_lint:
+  errors:
+    rule_name_2: info
+    rule_name_3: error
+''');
+      final configs = CustomLintConfigs.parse(analysisOptions, packageConfig);
+
+      expect(configs.errors, {
+        'rule_name_1': ErrorSeverity.ERROR,
+        'rule_name_2': ErrorSeverity.INFO,
+        'rule_name_3': ErrorSeverity.ERROR,
+      });
+    });
+
     group('package config', () {
       test('single package', () async {
         final dir = createDir();
@@ -353,7 +436,6 @@ foo:
 
       test('workspace', () async {
         final dir = createDir();
-        print(dir);
         final projectPath = await createTempProject(
           tempDirPath: dir.path,
           projectName: testPackageName,