Skip to content

refactor: Security Rules - use the default storage bucket from AppOptions and tests #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
demolaf merged 27 commits into from
Jan 5, 2026
Merged

refactor: Security Rules - use the default storage bucket from AppOptions and tests #119

demolaf merged 27 commits into from
Jan 5, 2026

Conversation

@demolaf
Copy link
Member

@demolaf demolaf commented Jan 5, 2026 •
edited
Loading

  • Added optional bucket parameters to Storage methods with defaults from app.options.storageBucket
  • Added more unit and integration tests

demolaf added 24 commits December 18, 2025 16:46
@demolaf
refactor(messaging): rename _toProto methods to _toRequest for messag…
9d929c9 
…e serialization
@demolaf
feat(messaging): add topic subscription and unsubscription APIs with …
c6fbf37 
…validation and tests
@demolaf
wip: add Cloud Run example server with messaging and token verificati…
c57ea41 
…on APIs
@demolaf
feat(messaging): complete implementation with tests and bug fixes
37a6862
@demolaf
chore: lint errors
f5aa639
@demolaf
chore: fix lint errors
5c3f9c8
@demolaf
feat(functions): add Cloud Functions Task Queue admin API with valida…
56436b9 
…tion and error handling
@demolaf
refactor: rename client param to api x_http_client.dart
bd93379
@demolaf
wip: add Cloud Tasks emulator support with URL rewriting and env dete…
5f3cd90 
…ction
@demolaf
test: add integration and unit tests for Task Queue, enqueue, delete
4ea24a0
@demolaf
test: add comprehensive unit tests for Functions TaskQueue, validatio…
3915eca 
…n, and error handling
@demolaf
fix: use existing test service account credentials
0bbabb6 
- add functions ts example project for functionsExample method in example/main.dart
@demolaf
chore: add package-lock.json to .gitignore
a21645c
@demolaf
refactor: update taskQueue to use named extensionId parameter and upd…
866fbbf 
…ate tests
@demolaf
chore: add documentation generation and deployment workflow
7106284 
- Add docs.yml GitHub Actions workflow for building and deploying documentation to GitHub Pages
- Add generate-docs.sh script for generating package documentation
- Update .gitignore to exclude generated docs
- Add index.html landing page for documentation
- Update melos scripts in pubspec.yaml to support docs generation
@demolaf
Update docs workflow to allow manual deployment
b1aa124
@demolaf
fix: update to latest GitHub Pages actions
161c478
@demolaf
fix: update flutter-action to latest v2 to resolve set-output depreca…
76796b5 
…tion warnings
@demolaf
temp: allow deployment on PRs for testing
30d16cd
@demolaf
temp: remove environment protection for testing
7604d09
@demolaf
chore: restore production docs deployment configuration
52a2918
@demolaf
refactor: use the default storage bucket from AppOptions if no buck…
2ba22b6 
…et name is provided.
@demolaf
fix: add mapping for 'INVALID_ARGUMENT' to FirebaseSecurityRulesError…
717257f 
…Code
@demolaf
test: add tests for SecurityRules functionality
cd5d48f
@demolaf demolaf marked this pull request as draft January 5, 2026 15:02
@github-actions
Copy link

github-actions bot commented Jan 5, 2026 •
edited
Loading

Coverage Report

✅ Coverage 71.81% meets 40% threshold

Coverage: 71.81%
Lines Covered: 3719/5179

Minimum threshold: 40%

@demolaf demolaf changed the title Security rules/apis refactor: use the default storage bucket from AppOptions and tests Jan 5, 2026
@demolaf demolaf marked this pull request as ready for review January 5, 2026 15:17
Base automatically changed from gen-docs to next January 5, 2026 15:23
@demolaf demolaf changed the title refactor: use the default storage bucket from AppOptions and tests refactor: Security Rules - use the default storage bucket from AppOptions and tests Jan 5, 2026
@demolaf demolaf merged commit 61bfe94 into next Jan 5, 2026
9 checks passed
@demolaf demolaf deleted the security-rules/apis branch January 5, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@demolaf