Skip to content

Conversation

@CorieW
Copy link
Member

@CorieW CorieW commented Jan 6, 2026

fixes firebase#3888

  • Removes system message concatenation.
    • Removed related tests
  • Removes cacheSystemPrompt

Test app covers:

  • System prompt caching
  • User prompt caching
  • Tool prompt caching
  • Image prompt caching
  • PDF prompt caching

Copy link
Collaborator

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm! nicely done. fairly minor comments

@CorieW
Copy link
Member Author

CorieW commented Jan 7, 2026

Ugh. Looks like there's an issue with VertexAI from using a diff Anthropic SDK version to it in the Anthropic testapps?

@cabljac cabljac self-requested a review January 12, 2026 09:38
@CorieW CorieW marked this pull request as ready for review January 12, 2026 12:47
@github-actions github-actions bot added the docs label Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JS - Anthropic 1P Plugin]: Support Prompt Caching

4 participants