-
Notifications
You must be signed in to change notification settings - Fork 232
feat(android): introduce new prop fullScreen to adjust dialog screen size #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ab2d19a
feat: introduce new prop fullScreen
NJ-2020 65c4750
remove uncessary changes
NJ-2020 b4dacbf
remove unnecessary changes
NJ-2020 487559a
fix error
NJ-2020 f7df6ae
Merge remote-tracking branch 'origin' into fix/377
NJ-2020 b099105
fix: make fullScreen flag optional
NJ-2020 1fe1a84
fix: typedoc for fullScreen
NJ-2020 d5d38fc
fix: build error
NJ-2020 27f3905
fix: fullScreen mode typedocs description
NJ-2020 a97a07a
fix: fullScreen type description
NJ-2020 e67c698
fix fullScreen default value
NJ-2020 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This becomes redundant if fullScreen is false. It could go in the else block for the condition below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: when fullScreen is false, we're not rewriting the style over it, instead we only set/update the windowIsFloating style value to true
https://github.com/NJ-2020/react-native-apple-authentication/blob/b4dacbffa9265a3393e807d197d012dce5f47ba1/android/src/main/java/com/RNAppleAuthentication/webview/SignInWebViewDialogFragment.kt#L45-L48
https://github.com/NJ-2020/react-native-apple-authentication/blob/b4dacbffa9265a3393e807d197d012dce5f47ba1/android/src/main/java/com/RNAppleAuthentication/webview/SignInWebViewDialogFragment.kt#L45-L48
Please lmk if I am missing something. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough 👍