Skip to content

Commit 50ecf38

Browse files
committed
lint(e2e): turn off remaining mocha lint violations
some of them may have value, but the majority of the value has been captured now
1 parent 595256e commit 50ecf38

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.eslintrc.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ module.exports = {
4141
'@typescript-eslint/no-empty-function': 'off',
4242
// off for validation tests
4343
'@typescript-eslint/ban-ts-ignore': 'off',
44+
'mocha/no-skipped-tests': 'off', // we skip tests for a reason, frequently
45+
'mocha/no-top-level-hooks': 'off', // potentially has value if anyone wants to refactor
46+
'mocha/no-hooks-for-single-case': 'off', // potentially has value
47+
'mocha/no-setup-in-describe': 'off', // potentially has value, large refactor here though
48+
4449
},
4550
globals: {
4651
__DEV__: true,

packages/app/e2e/app.e2e.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ describe('firebase', function() {
5353
});
5454
});
5555

56+
// eslint-disable-next-line mocha/max-top-level-suites
5657
describe('firebase -> X', function() {
5758
it('apps should provide an array of apps', function() {
5859
should.equal(!!firebase.apps.length, true);

0 commit comments

Comments
 (0)