fix(analytics,web): sets no-cors on analytics requests for web #8238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the following discussion for more details: invertase#7982 (reply in thread)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Contributor
Author
mikehardy
reviewed
Jan 19, 2025
Collaborator
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
Thank you for posting this, and really, thanks for digging in and figuring it out. Much appreciated.
Do you think this line should go as it is redundant now?
mikehardy
added
Workflow: Waiting for User Response
Contributor
Author
|
Yup, done, also retested with that line removed and verified we still get an HTTP 204 from Google Analytics. |
Contributor
Author
Done. |
mikehardy
approved these changes
Jan 20, 2025
Collaborator
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
A thing of beauty - thanks again
mikehardy
removed
Workflow: Waiting for User Response
Collaborator
|
It's in the publish queue now, should be out on npmjs.com in a minute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requests to Google analytics for web aren't setting no-cors so requests are triggering CORS preflight and subsequently failing.
See the following discussion for more details: #7982 (reply in thread)
Related issues
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Tested manually in Chrome. I verified that no CORS preflight is sent and that I received an HTTP 204 response from my Google analytics request.
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter