-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(functions): turbo modules implementation #8603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| describe('onConfigUpdate', function () { | ||
| // SKIPPED: Skipping suite of onConfigUpdate tests until they're fixed | ||
| describe.skip('onConfigUpdate', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cherry-picked this commit to a clean branch for separate PR to get it in now for all PRs until fixed, once it merges to main for everyone's benefit you'll want to rebase it out over on this PR. Cool feature, but such a hassle.
| "@react-native-firebase/private-tests-firebase-functions": "^0.0.1", | ||
| "react-native": "^0.80.1", | ||
| "react-native-builder-bob": "^0.40.12", | ||
| "typescript": "^5.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this and put path to TypeScript executable. See: https://github.com/invertase/react-native-firebase/pull/8651/files#diff-d1b85f8d1f6297c72a7aa703ba620c7eb120ea77be0538faed320a306eeab865R80
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter