Skip to content

fix: add missing 'FirebaseAnalytics/Core' to podspec #8607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add missing 'FirebaseAnalytics/Core' to podspec #8607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/analytics/RNFBAnalytics.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Pod::Spec.new do |s|
# Firebase dependencies
if defined?($RNFirebaseAnalyticsWithoutAdIdSupport) && ($RNFirebaseAnalyticsWithoutAdIdSupport == true)
Pod::UI.puts "#{s.name}: Not installing FirebaseAnalytics/IdentitySupport Pod, no IDFA will be collected."
s.dependency 'FirebaseAnalytics/Core', firebase_sdk_version
Comment on lines 42 to +44
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new pod arrangement for FirebaseAnalytics pods + sub-pods, combined with our desire to allow folks to have fine-grained control with Podfile variable toggles so that all parts are optional, we need to start with FirebaseAnalytics/Core for all arrangements and then go from there

I think it may work to have the Core sub-spec in the conditional because of transitive dependencies bringing it in some of the conditional branches where it is needed, but...

I think it's most correct to always start with it as a dependency, outside of all conditionals, and then go

What do you think @radko93 ? I think this is most correct and if I don't hear back I'm going to commit and release it so we don't have the broken 22.3.0 version out too long...

Suggested change
if defined?($RNFirebaseAnalyticsWithoutAdIdSupport) && ($RNFirebaseAnalyticsWithoutAdIdSupport == true)
Pod::UI.puts "#{s.name}: Not installing FirebaseAnalytics/IdentitySupport Pod, no IDFA will be collected."
s.dependency 'FirebaseAnalytics/Core', firebase_sdk_version
s.dependency 'FirebaseAnalytics/Core', firebase_sdk_version
if defined?($RNFirebaseAnalyticsWithoutAdIdSupport) && ($RNFirebaseAnalyticsWithoutAdIdSupport == true)
Pod::UI.puts "#{s.name}: Not installing FirebaseAnalytics/IdentitySupport Pod, no IDFA will be collected."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going with the other PR, but I appreciate this and sorry for the trouble!

else
if !defined?($RNFirebaseAnalyticsWithoutAdIdSupport)
Pod::UI.puts "#{s.name}: Using FirebaseAnalytics/IdentitySupport with Ad Ids. May require App Tracking Transparency. Not allowed for Kids apps."
Expand Down
Loading