fix(ios): use react-native podspec module infra for deps #8836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `install_modules_dependencies` method has existed since much longer than our lowest supported react-native version so should be safe to call the important thing it does is include the correct pods for modules that have been converted to TurboModules, and this fixes compile errors that do not show up on react-native 0.78 but do show up on current react-native
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
russellwheatley
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the
install_modules_dependenciesmethod has existed since much longer (specifically, react-native 0.71) than our lowest supported react-native version so should be safe to add a call to it in a non-breaking changethe important thing it does is include the correct pods for modules that have been converted to TurboModules, and this fixes compile errors that do not show up on react-native 0.78 but do show up on current react-native
Related issues
Noticed this while testing fixes for the following related issue - no one else had noticed it there yet, but it was something that broke between 23.7.0 and 23.8.0 with functions converting to TurboModules
Release Summary
it is a fix commit, it should generate a new fix version
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
This shows up in https://github.com/mikehardy/rnfbdemo/blob/main/make-demo.sh if you set the react-native-firebase version to 23.8.0 through 23.8.2, but does not show up when using 23.7.0 - indicating it was TurboModules conversion that did it
Some credit to the folks at react-native-gesture-handler (and @j-piasecki @cipolleschi) - search for my compile failure led me to that repo, and as a popular new architecture module it was a good reference to examine their podspec and see their solutions back in time as well as current state of the art
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter