Skip to content

Conversation

@mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Jan 17, 2026

Description

When we released 23.8.0 we had several problems related to packaging that would have been visible if we ran our tests against locally created packages (as if they were from npmjs.com the way library users consume them) vs our development-style of symlinking the code into the live source tree

This PR will enable us to run tests in CI using locally created packages so we should see those problems pre-publish instead of when users notice them and file issues

Related issues

Release Summary

This is a testing PR, no release should happen

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  • ✅ test patch-package generation result after abstract the script that creates locally created packages from the patch-package flow by comparing downloaded patches.zip vs expectations
  • ❓ either convert all test workflows to run against local packages, or add a matrix where some is symlinked and some is locally created packages, need to check how each work first but not there yet

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jan 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
react-native-firebase Ready Ready Preview, Comment Jan 17, 2026 4:11pm

Request Review

@mikehardy mikehardy marked this pull request as draft January 17, 2026 14:51
@mikehardy mikehardy force-pushed the @mikehardy/test-with-local-packages branch from 8f016ac to 91a75ba Compare January 17, 2026 14:54
this will be reused in other flows to create local packages prior
to testing, for use in the testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants