Skip to content

fix(app): tolerate missing NativeError.userInfo property in NativeFirebaseError constructor #8843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mikehardy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(app): tolerate missing NativeError.userInfo property in NativeFirebaseError constructor #8843

mikehardy wants to merge 2 commits into from
+28 −11

Conversation

@mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Jan 17, 2026

Description

Apparently the userInfo property may be missing entirely on NativeError, but this wasn't safely handled in NativeFirebaseError

  • Change the typescript def of NativeError to recognize that userInfo property was optional / possibly-undefined
  • Repaired the constructor to correspond to the new definition
  • Added a test to make sure that NativeError.userInfo === undefined case was handled

Related issues

Release Summary

fix release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I added a unit test to probe the condition as observed in reality, and it did fail prior to the changes here

I made the changes here and re-ran the test, and it passed

While running yarn tests:jest I noticed some deprecation warnings in functions jest tests and repaired those in a separate commit since I was in the unit testing area...

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy
fix(app): tolerate missing userInfo in NativeError
cd841c9 
previously a missing NativeError.userInfo would crash
the constructor of NativeFirebaseError as it was expected to be defined

with this change we will tolerate a completely missing userInfo property
@mikehardy
test(functions): avoid deprecated methods in modular tests
83f7598
@vercel
Copy link

vercel bot commented Jan 17, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
react-native-firebase Ready Ready Preview, Comment Jan 17, 2026 6:20pm

Request Review

@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Jan 17, 2026
@mikehardy mikehardy mentioned this pull request Jan 17, 2026
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellwheatley russellwheatley Awaiting requested review from russellwheatley

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Workflow: Needs Review Pending feedback or review from a maintainer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛] NativeFirebaseError constructor crashes on real-world input: Cannot read property 'code' of undefined 🔥

2 participants

@mikehardy