Skip to content

Conversation

@stage88
Copy link
Contributor

@stage88 stage88 commented Feb 26, 2025

Description

React Native 0.77 removes BaseViewManagerInterface, this PR follows a similar approach applied here to add support for RN77 and old architecture.

According to this, the change should be backwards compatible with older versions of RN.

Related issues

Fixes #701.

Release Summary

Updated old architecture code to support React Native 0.77 on Android.

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

This should be covered by the CI, although requires the example project to be updated to RN77.


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

@docs-page
Copy link

docs-page bot commented Feb 26, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-mobile-ads~714

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2025

CLA assistant check
All committers have signed the CLA.

@dylancom dylancom requested a review from mikehardy February 26, 2025 09:31
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.24%. Comparing base (a34c7ba) to head (8d4a2a0).
Report is 115 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   43.72%   37.24%   -6.48%     
==========================================
  Files          30       36       +6     
  Lines         549      658     +109     
  Branches      151      169      +18     
==========================================
+ Hits          240      245       +5     
- Misses        309      413     +104     

@dylancom
Copy link
Collaborator

Thanks for your PR!
Please run: npm run lint:android || yarn run lint:android to fix formatting issues.

@stage88
Copy link
Contributor Author

stage88 commented Feb 26, 2025

Thanks for your PR! Please run: npm run lint:android || yarn run lint:android to fix formatting issues.

Done!

@dylancom dylancom merged commit 39e3f7d into invertase:main Feb 26, 2025
3 checks passed
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 14.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛] Android - build fail on react-native 0.77

4 participants