fix(expo): make the config plugin idempotent#752
Merged
dylancom merged 1 commit intoinvertase:mainfrom May 23, 2025
Merged
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~752 Documentation is deployed and generated using docs.page. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 43.72% 37.24% -6.48%
==========================================
Files 30 36 +6
Lines 549 658 +109
Branches 151 169 +18
==========================================
+ Hits 240 245 +5
- Misses 309 413 +104 🚀 New features to boost your workflow:
|
dylancom
requested changes
May 23, 2025
plugin/src/index.ts
Outdated
| 'android:value', | ||
| ); | ||
|
|
||
| if (!existingItem) { |
Collaborator
There was a problem hiding this comment.
If it exists, we should update it with the latest value i think?
Contributor
Author
There was a problem hiding this comment.
I thought about it for a little, and yes, overwriting values put into the manifest by hand or other config plugins sounds reasonable. I updated the PR.
DoctorJohn
force-pushed
the
make-the-expo-plugin-idempotent
branch
from
96b27a0 to
56372e3
Compare
Collaborator
|
🎉 This PR is included in version 15.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the expo config plugin idempotent (i.e.,
npx expo prebuildcan now be run idempotent without duplicate values ending up in any manifests).Related issues
Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
🔥