Skip to content

Conversation

DominikHinc
Copy link

@DominikHinc DominikHinc commented Aug 11, 2025

Fix enum bindings on android, fix wrong property being extracted on iOS, pass values specified in documentation to the native side, add customControlsRequested prop

Description

The code does not work as it is specified in the documentation, the request option params are ignored

Related issues

This PR fixes #703

Release Summary

  • Fix enum bindings on android;
  • Fix wrong property being extracted on iOS;
  • Pass values specified in documentation to the native side;
  • Add customControlsRequested prop.

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • [x ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

…OS, pass values specified in documentation to the native side, add customControlsRequested prop
Copy link

docs-page bot commented Aug 11, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-mobile-ads~782

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dominik Hinc seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.34%. Comparing base (a34c7ba) to head (0cf6300).
⚠️ Report is 150 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   43.72%   36.34%   -7.37%     
==========================================
  Files          30       36       +6     
  Lines         549      677     +128     
  Branches      151      178      +27     
==========================================
+ Hits          240      246       +6     
- Misses        309      431     +122     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dylancom
Copy link
Collaborator

dylancom commented Aug 14, 2025

Thanks for your contribution! Could you maybe split this into separate PR's?

dylancom added a commit that referenced this pull request Aug 19, 2025
dylancom added a commit that referenced this pull request Aug 19, 2025
dylancom added a commit that referenced this pull request Aug 19, 2025
@dylancom
Copy link
Collaborator

As I haven't heard back from you I splitted the fixes, improved the NativeAdRequestOptions validation and credited you in the commits.

Thanks for your work!
"Add customControlsRequested prop." is still open so if you want you can update this PR when you have time.

github-actions bot pushed a commit that referenced this pull request Aug 19, 2025
### [15.4.2](v15.4.1...v15.4.2) (2025-08-19)

### Bug Fixes

* **android:** native ad enum bindings (split from [#782](#782)) ([574c479](574c479))
* **iOS:** wrong property being extracted in native ad (split from [#782](#782)) ([8a6a13d](8a6a13d))
* passing native ad request options to native side (split from [#782](#782)) ([d6ef5e2](d6ef5e2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Native Ads request options ignored
3 participants