-
-
Notifications
You must be signed in to change notification settings - Fork 182
Fix enum bindings #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix enum bindings #782
Conversation
…OS, pass values specified in documentation to the native side, add customControlsRequested prop
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~782 Documentation is deployed and generated using docs.page. |
Dominik Hinc seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
==========================================
- Coverage 43.72% 36.34% -7.37%
==========================================
Files 30 36 +6
Lines 549 677 +128
Branches 151 178 +27
==========================================
+ Hits 240 246 +6
- Misses 309 431 +122 🚀 New features to boost your workflow:
|
Thanks for your contribution! Could you maybe split this into separate PR's? |
Co-authored-by: Dominik Hinc <[email protected]>
Co-authored-by: Dominik Hinc <[email protected]>
Co-authored-by: Dominik Hinc <[email protected]>
As I haven't heard back from you I splitted the fixes, improved the NativeAdRequestOptions validation and credited you in the commits. Thanks for your work! |
### [15.4.2](v15.4.1...v15.4.2) (2025-08-19) ### Bug Fixes * **android:** native ad enum bindings (split from [#782](#782)) ([574c479](574c479)) * **iOS:** wrong property being extracted in native ad (split from [#782](#782)) ([8a6a13d](8a6a13d)) * passing native ad request options to native side (split from [#782](#782)) ([d6ef5e2](d6ef5e2))
Fix enum bindings on android, fix wrong property being extracted on iOS, pass values specified in documentation to the native side, add customControlsRequested prop
Description
The code does not work as it is specified in the documentation, the request option params are ignored
Related issues
This PR fixes #703
Release Summary
Checklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__