fix(deps): adopt current stable native admob SDKs #830
+3,345
−6,093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the runtime crash "TurboModuleRegistry.getEnforcing(...): 'RNAppModule' not found" when using React Native 0.83+ with mandatory New Architecture. Changes: - Create NativeAppModule.ts TurboModule spec for Codegen - Update ReactNativeAppModule.java to extend NativeAppModuleSpec - Update GoogleMobileAdsNativeEventEmitter.ts to use TurboModule import - Enable isTurboModule flag for RNAppModule in Package.kt The RNAppModule (internal event handling module) was the only module not properly configured as a TurboModule. While other modules like RNGoogleMobileAdsModule had proper TurboModule support, RNAppModule extended ReactNativeModule (bridge-based) and had isTurboModule=false hardcoded in the package registration. Fixes #XXX
- Add jest mock for NativeAppModule in jest.setup.ts - Add unit tests for GoogleMobileAdsNativeEventEmitter in __tests__/ - Add e2e test for module initialization in e2e/admob.e2e.js Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change UnsafeObject import from deep path to 'react-native' root export - Remove unused @nonnull import in ReactNativeAppModule.java Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The module initialization test was functionally equivalent to the existing 'should match text in the basic app element' test. Both verify the app loads correctly, which implicitly tests TurboModule initialization. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update the example app to RN 0.83.1 to properly test TurboModule support for RNAppModule, which requires the root-level UnsafeObject export introduced in RN 0.83+. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update react-native and @react-native/babel-preset to 0.83.1 in the root package.json to ensure TypeScript compilation works with the UnsafeObject root-level export that was introduced in RN 0.83. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
need to reference it from the correct spot on the root import
I find those to be very bothersome, if we specify the versions and have a lock file there it implies maintenance of the versions and the lockfile But the ruby ecosystem and management of those versions is an entire and separate side quest unrelated to the mission of this repo ...and in practice "the current version of cocopaods" works. Just let the version installed on the system work
the native SDKs are just patch releases, but I saw notices in the native logs complaining they were not up to date, so I found the latest versions in release notes and adopted them
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~830 Documentation is deployed and generated using docs.page. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says in the title
also deleted a personal-developer-only file that shouldn't have been in the repo and .gitignore'd it, and switched to relying on system installed cocoapods version vs the Gemfile - it was out of date and updating it is pointless work
Related issues
Only the last 3 commits here are the new PR, it is based on the existing PR that finishes TurboModules work for Android:
...after that's merged I'll rebase those commits out of here and re-push
Reviewers should review commit by commit, and just look at the last 3
Release Summary
fix release via conventional commits
Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
Everything seemed to work fine and it eliminated native warnings for me that the SDKs were out of date
Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter