fix(types): add trial_period_days to createCheckoutSession options #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing `trial_period_days` field to `CommonSessionCreateParams` in the client SDK. This resolves a false-positive TypeScript error when using the `createCheckoutSession` function with a trial period, even though the backend supports it as of commit e9ee79e (January 2024). This change improves developer experience by aligning the client-side types with the backend implementation and avoiding misleading IDE or build-time errors.
|
|
Jaimealdon
approved these changes
May 15, 2025
Fixed a typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing
trial_period_daysfield toCommonSessionCreateParamsin the client SDK.This resolves a false-positive TypeScript error when using the
createCheckoutSessionfunction with a trial period, even though the backend supports it as of commit e9ee79e (January 2024).This change improves developer experience by aligning the client-side types with the backend implementation and avoiding misleading IDE or build-time errors.