Skip to content

Fix invoice.upcoming webhook handler failure - generate unique document ID for invoices without id #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from
Draft

Fix invoice.upcoming webhook handler failure - generate unique document ID for invoices without id #706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20c0107
Initial plan
Copilot Jul 24, 2025
6859472
Fix invoice.upcoming webhook handling - generate ID for invoices with…
Copilot Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions firestore-stripe-payments/functions/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,16 @@ export const insertInvoiceRecord = async (invoice: Stripe.Invoice) => {
if (customersSnap.size !== 1) {
throw new Error('User not found!');
}

// For upcoming invoices, generate a unique document ID since they don't have an id
const invoiceDocId = invoice.id || `upcoming_${invoice.subscription}_${Date.now()}`;

// Write to invoice to a subcollection on the subscription doc.
await customersSnap.docs[0].ref
.collection('subscriptions')
.doc(invoice.subscription as string)
.collection('invoices')
.doc(invoice.id)
.doc(invoiceDocId)
.set(invoice);

const prices = [];
Expand All @@ -341,15 +345,18 @@ export const insertInvoiceRecord = async (invoice: Stripe.Invoice) => {
);
}

// An Invoice object does not always have an associated Payment Intent
// Only create payment records for invoices that have a payment_intent or id
// Upcoming invoices are previews and don't represent actual payments
const recordId: string = (invoice.payment_intent as string) ?? invoice.id;

// Update subscription payment with price data
await customersSnap.docs[0].ref
.collection('payments')
.doc(recordId)
.set({ prices }, { merge: true });
logs.firestoreDocCreated('invoices', invoice.id);
if (recordId) {
// Update subscription payment with price data
await customersSnap.docs[0].ref
.collection('payments')
.doc(recordId)
.set({ prices }, { merge: true });
}

logs.firestoreDocCreated('invoices', invoiceDocId);
};

/**
Expand Down