feat: add useConnectQuery and useConnectMutation #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~129 Documentation is deployed and generated using docs.page. |
HassanBahati
changed the title
HassanBahati
commented
Nov 27, 2024
| Data = ReturnType<Fn> extends MutationRef<infer D, any> ? D : never, | ||
| Variables = Fn extends ( | ||
| dc: DataConnect, | ||
| vars: infer V |
Member
Author
There was a problem hiding this comment.
allowing for DataConnect class instance and or just variables where the ref function can infer the variables directly given that the refs accommodate for this. for example this is a snapshot from the generated sdk for movies connector
…o reslove locally
Ehesp
reviewed
Dec 16, 2024
| TError = FirebaseError, | ||
| Variables = unknown | ||
| > = Omit<UseMutationOptions<TData, TError, Variables>, "mutationFn"> & { | ||
| invalidate?: QueryRef<unknown, unknown>[]; |
Member
There was a problem hiding this comment.
I'll bring this one up, but I'm thinking we should try to support both a QueryRef & the inferred function function where we can just take the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
useConnectQueryanduseConnectMutation