-
Notifications
You must be signed in to change notification settings - Fork 72
Add SDK Tracking #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDK Tracking #160
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~160 Documentation is deployed and generated using docs.page. |
| const mutationRef = typeof ref === "function" ? ref(variables) : ref; | ||
|
|
||
| // @ts-expect-error function is hidden under `DataConnect`. | ||
| mutationRef.dataConnect._setCallerSdkType(_callerSdkType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of calling _setCallerSdkType() here, we're planning to pass the _callerSdkType as an argument to the ref function, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think calling _setCallerSdkType on the Data Connect object would be preferred because the mutation hook accepts a ref function OR a ref that has already been created.
| } | ||
|
|
||
| // @ts-expect-error function is hidden under `DataConnect`. | ||
| queryRef.dataConnect._setCallerSdkType(_callerSdkType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of calling _setCallerSdkType() here, we're planning to pass the _callerSdkType as an argument to the ref function, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
Waiting on
_setCallerSdkTypeto be added to the core SDK