Skip to content

Conversation

@maneesht
Copy link
Collaborator

Waiting on _setCallerSdkType to be added to the core SDK

@docs-page
Copy link

docs-page bot commented Jan 31, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~160

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2025

CLA assistant check
All committers have signed the CLA.

const mutationRef = typeof ref === "function" ? ref(variables) : ref;

// @ts-expect-error function is hidden under `DataConnect`.
mutationRef.dataConnect._setCallerSdkType(_callerSdkType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of calling _setCallerSdkType() here, we're planning to pass the _callerSdkType as an argument to the ref function, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think calling _setCallerSdkType on the Data Connect object would be preferred because the mutation hook accepts a ref function OR a ref that has already been created.

}

// @ts-expect-error function is hidden under `DataConnect`.
queryRef.dataConnect._setCallerSdkType(_callerSdkType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of calling _setCallerSdkType() here, we're planning to pass the _callerSdkType as an argument to the ref function, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@maneesht maneesht closed this Feb 5, 2025
@maneesht maneesht deleted the mtewani/add-tracking branch February 5, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants