-
Notifications
You must be signed in to change notification settings - Fork 71
fix: ensure updated variables get picked up (rebase) #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2817fef
Fixed issue where updated variables weren't getting picked up
maneesht b352170
Removed unnecessary dependency
maneesht 0d1c2f6
Fixed formatting
maneesht d598920
Fixed imports
maneesht e1fd2a0
Added case for when both vars are equivalent
maneesht 4aad4be
Fixed file
maneesht 6ac5275
chore: bump react package version
cabljac 90de989
Update packages/react/src/data-connect/utils.test.ts
cabljac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,49 @@ | ||
| { | ||
| "name": "@tanstack-query-firebase/react", | ||
| "version": "2.0.0", | ||
| "description": "TanStack Query bindings for Firebase and React", | ||
| "type": "module", | ||
| "scripts": { | ||
| "test": "vitest --dom --coverage", | ||
| "build": "tsup", | ||
| "serve:coverage": "npx serve coverage", | ||
| "emulator": "firebase emulators:start --project test-project", | ||
| "emulator:kill": "lsof -t -i:4001 -i:8080 -i:9000 -i:9099 -i:9199 -i:8085 | xargs kill -9", | ||
| "check": "tsc --noEmit", | ||
| "publish-package": "pnpm run build && cd dist && npm publish" | ||
| }, | ||
| "exports": { | ||
| ".": { | ||
| "import": "./index.js", | ||
| "types": "./index.d.ts" | ||
| }, | ||
| "./auth": { | ||
| "import": "./auth/index.js", | ||
| "types": "./auth/index.d.ts" | ||
| }, | ||
| "./firestore": { | ||
| "import": "./firestore/index.js", | ||
| "types": "./firestore/index.d.ts" | ||
| }, | ||
| "./data-connect": { | ||
| "import": "./data-connect/index.js", | ||
| "types": "./data-connect/index.d.ts" | ||
| } | ||
| }, | ||
| "author": { | ||
| "name": "Invertase", | ||
| "email": "[email protected]", | ||
| "url": "https://github.com/invertase/tanstack-query-firebase" | ||
| }, | ||
| "license": "Apache-2.0", | ||
| "devDependencies": { | ||
| "@dataconnect/default-connector": "workspace:*", | ||
| "@testing-library/react": "^16.0.1", | ||
| "@types/react": "^19.0.1", | ||
| "react": "^19.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@tanstack/react-query": "^5", | ||
| "firebase": "^11.3.0" | ||
| } | ||
| "name": "@tanstack-query-firebase/react", | ||
| "version": "2.0.1", | ||
| "description": "TanStack Query bindings for Firebase and React", | ||
| "type": "module", | ||
| "scripts": { | ||
| "test": "vitest --dom --coverage", | ||
| "build": "tsup", | ||
| "serve:coverage": "npx serve coverage", | ||
| "emulator": "firebase emulators:start --project test-project", | ||
| "emulator:kill": "lsof -t -i:4001 -i:8080 -i:9000 -i:9099 -i:9199 -i:8085 | xargs kill -9", | ||
| "check": "tsc --noEmit", | ||
| "publish-package": "pnpm run build && cd dist && npm publish" | ||
| }, | ||
| "exports": { | ||
| ".": { | ||
| "import": "./index.js", | ||
| "types": "./index.d.ts" | ||
| }, | ||
| "./auth": { | ||
| "import": "./auth/index.js", | ||
| "types": "./auth/index.d.ts" | ||
| }, | ||
| "./firestore": { | ||
| "import": "./firestore/index.js", | ||
| "types": "./firestore/index.d.ts" | ||
| }, | ||
| "./data-connect": { | ||
| "import": "./data-connect/index.js", | ||
| "types": "./data-connect/index.d.ts" | ||
| } | ||
| }, | ||
| "author": { | ||
| "name": "Invertase", | ||
| "email": "[email protected]", | ||
| "url": "https://github.com/invertase/tanstack-query-firebase" | ||
| }, | ||
| "license": "Apache-2.0", | ||
| "devDependencies": { | ||
| "@dataconnect/default-connector": "workspace:*", | ||
| "@testing-library/react": "^16.0.1", | ||
| "@types/react": "^19.0.1", | ||
| "react": "^19.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@tanstack/react-query": "^5", | ||
| "firebase": "^11.3.0" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One difference here, #180 seems to have the bumped version at
2.0.8, I believe2.0.1in here is okay