Skip to content

Conversation

@cabljac
Copy link
Collaborator

@cabljac cabljac commented Jul 28, 2025

No description provided.

Copilot AI review requested due to automatic review settings July 28, 2025 09:34
@docs-page
Copy link

docs-page bot commented Jul 28, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~196

Documentation is deployed and generated using docs.page.

This comment was marked as outdated.

@cabljac cabljac force-pushed the @invertase/changeset-ci branch from 8614f21 to 28be9e5 Compare July 28, 2025 09:39
@cabljac cabljac requested a review from Copilot July 28, 2025 09:39

This comment was marked as outdated.

@cabljac cabljac force-pushed the @invertase/changeset-ci branch from 28be9e5 to cffcb65 Compare July 28, 2025 09:46
@cabljac cabljac requested a review from Copilot July 28, 2025 09:46

This comment was marked as outdated.

@cabljac cabljac requested a review from Copilot July 28, 2025 09:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CI validation to ensure that changesets are created when packages are modified. The CI workflow now checks for package changes and enforces the presence of corresponding changesets to maintain proper release management.

  • Adds changeset validation to the quality job in the tests workflow
  • Updates changeset commands to use more robust find operations instead of shell globbing
  • Adds fetch-depth: 0 to checkout actions to enable proper git history access

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/tests.yaml Adds changeset validation step and configures full git history checkout
.github/workflows/release.yml Updates changeset validation commands to use more robust file finding
Comments suppressed due to low confidence (1)

.github/workflows/tests.yaml:38

  • The step ID 'quality-changes' is misleading since this step determines package changes, not quality changes. Consider renaming to 'package-changes' or 'changed-packages' for clarity.
        id: quality-changes

- name: Check for changesets
run: |
# Check if any packages have changed
if [[ "${{ steps.quality-changes.outputs.react }}" == "true" ]] || [[ "${{ steps.quality-changes.outputs.angular }}" == "true" ]]; then
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition logic is duplicated in lines 50, 59, and 62. Consider storing the package change detection in a variable or using a more maintainable approach to avoid repetition.

Suggested change
if [[ "${{ steps.quality-changes.outputs.react }}" == "true" ]] || [[ "${{ steps.quality-changes.outputs.angular }}" == "true" ]]; then
packages_changed=$([[ "${{ steps.quality-changes.outputs.react }}" == "true" ]] || [[ "${{ steps.quality-changes.outputs.angular }}" == "true" ]])
if [[ "$packages_changed" == "true" ]]; then

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants