-
Notifications
You must be signed in to change notification settings - Fork 72
ci: add CI for checking generated changesets #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~196 Documentation is deployed and generated using docs.page. |
8614f21 to
28be9e5
Compare
28be9e5 to
cffcb65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds CI validation to ensure that changesets are created when packages are modified. The CI workflow now checks for package changes and enforces the presence of corresponding changesets to maintain proper release management.
- Adds changeset validation to the quality job in the tests workflow
- Updates changeset commands to use more robust
findoperations instead of shell globbing - Adds fetch-depth: 0 to checkout actions to enable proper git history access
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/tests.yaml | Adds changeset validation step and configures full git history checkout |
| .github/workflows/release.yml | Updates changeset validation commands to use more robust file finding |
Comments suppressed due to low confidence (1)
.github/workflows/tests.yaml:38
- The step ID 'quality-changes' is misleading since this step determines package changes, not quality changes. Consider renaming to 'package-changes' or 'changed-packages' for clarity.
id: quality-changes
.github/workflows/tests.yaml
Outdated
| - name: Check for changesets | ||
| run: | | ||
| # Check if any packages have changed | ||
| if [[ "${{ steps.quality-changes.outputs.react }}" == "true" ]] || [[ "${{ steps.quality-changes.outputs.angular }}" == "true" ]]; then |
Copilot
AI
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition logic is duplicated in lines 50, 59, and 62. Consider storing the package change detection in a variable or using a more maintainable approach to avoid repetition.
| if [[ "${{ steps.quality-changes.outputs.react }}" == "true" ]] || [[ "${{ steps.quality-changes.outputs.angular }}" == "true" ]]; then | |
| packages_changed=$([[ "${{ steps.quality-changes.outputs.react }}" == "true" ]] || [[ "${{ steps.quality-changes.outputs.angular }}" == "true" ]]) | |
| if [[ "$packages_changed" == "true" ]]; then |
7147295 to
1bfef8f
Compare
No description provided.