chore(*): set ignore in changeset config #213
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~213 Documentation is deployed and generated using docs.page. |
|
There was a problem hiding this comment.
Pull Request Overview
This PR configures the changeset system to ignore changes in the examples directory when generating changelogs and version bumps.
- Updates the changeset configuration to exclude examples from release tracking
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a chore that updates the project's changeset configuration. The primary goal is to prevent the automatic generation of new changeset entries for modifications made within the examples directory, streamlining the release process by focusing changelog generation on core package changes.
Highlights
- Changeset Configuration: The
ignorearray in.changeset/config.jsonhas been updated to include"examples/**", ensuring that changes within theexamplesdirectory and its subdirectories will not trigger new changeset entries.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the changeset configuration to ignore packages in the examples directory. However, the ignore property is configured with a file path glob (examples/**) instead of the required package names. This will likely cause the configuration to not work as intended. My review includes a correction to use the actual package names from the example packages' package.json files.
| "baseBranch": "main", | ||
| "updateInternalDependencies": "patch", | ||
| "ignore": [] | ||
| "ignore": ["examples/**"] |
There was a problem hiding this comment.
The ignore field in the changeset configuration expects an array of package names, not file path globs. The pattern examples/** is a file path glob and will likely not work as intended to ignore the example packages.
To correctly ignore the example packages, you should list their names as defined in their respective package.json files. Based on the files in this repository, the package names are react-example and useGetIdTokenQuery.
| "ignore": ["examples/**"] | |
| "ignore": ["react-example", "useGetIdTokenQuery"] |
No description provided.