Skip to content

Conversation

@cabljac
Copy link
Collaborator

@cabljac cabljac commented Aug 27, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 27, 2025 10:55
@docs-page
Copy link

docs-page bot commented Aug 27, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~214

Documentation is deployed and generated using docs.page.

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025

⚠️ No Changeset found

Latest commit: f8c9554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the changeset ignore patterns by renaming example packages with an "example-" prefix and configuring changeset to ignore these packages.

  • Renames example packages to follow a consistent "example-*" naming pattern
  • Updates changeset configuration to ignore packages matching the "example-*" pattern
  • Ensures example packages won't trigger unnecessary version bumps in the release process

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
examples/react/useGetIdTokenQuery/package.json Renames package from "useGetIdTokenQuery" to "example-useGetIdTokenQuery"
examples/react/react-data-connect/package.json Renames package from "react-example" to "example-react-data-connect"
.changeset/config.json Adds "example-*" pattern to ignore list for changeset

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the configuration of the changeset tool to correctly ignore example projects during the release process. It involves updating the changeset configuration file to specify a new ignore pattern and subsequently renaming relevant example package names to align with this pattern, ensuring they are properly excluded from versioning and changelog generation.

Highlights

  • Changeset Configuration Update: The .changeset/config.json file has been modified to include "example-*" in its ignore array, ensuring that packages with names starting with "example-" are excluded from changeset's change detection.
  • Example Package Renaming: Two example package.json files (examples/react/react-data-connect/package.json and examples/react/useGetIdTokenQuery/package.json) have been updated to prefix their name fields with "example-", making them conform to the new changeset ignore pattern.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cabljac cabljac force-pushed the @invertase/fix-changeset branch from 6de2ddc to f8c9554 Compare August 27, 2025 10:56
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly configures changeset to ignore example packages. This is achieved by adding an ignore pattern to .changeset/config.json and renaming the example packages in examples/react/react-data-connect/package.json and examples/react/useGetIdTokenQuery/package.json to match this new pattern. The changes are consistent and effectively address the issue of preventing version bumps for example packages. The implementation is clean and follows best practices for managing monorepos with changeset.

@cabljac cabljac merged commit aa82edf into main Aug 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants