fix(ci): integrate trusted publishers #216
Conversation
|
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~216 Documentation is deployed and generated using docs.page. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces changes to standardize the naming of example packages and update the Changesets configuration to reflect this new convention. The primary goal is to ensure that example directories are correctly ignored by the Changesets tool, preventing them from being included in release notes or published inadvertently. This is a foundational step likely aimed at streamlining the continuous integration and publishing pipeline, potentially in preparation for integrating 'trusted publishers' as indicated by the PR title, by clearly defining what should and should not be part of the release process.
Highlights
- Example Package Naming Standardization: Renamed two example packages, 'react-example' to 'example-react-data-connect' and 'useGetIdTokenQuery' to 'example-useGetIdTokenQuery', to align with a new 'example-' prefix convention.
- Changeset Configuration Update: Modified the '.changeset/config.json' file to update the 'ignore' pattern for internal dependencies from 'examples/**' to 'example-*'. This change ensures that example packages, now following the 'example-' naming convention, are properly excluded from the automated versioning and publishing process managed by Changesets.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
cabljac
force-pushed
the
@invertase/release-ci
branch
from
1bcaaab to
efd8cd5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates trusted publishers with OpenID Connect (OIDC) for npm package publishing, replacing the traditional NPM_TOKEN authentication method. The changes also standardize example package naming conventions.
- Replace NPM_TOKEN with OIDC trusted publishing authentication
- Standardize example package names with "example-" prefix
- Remove changeset validation step and add environment-based publishing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Integrate OIDC authentication, add publish environment, remove changeset validation |
| .changeset/config.json | Update ignore pattern to match new example naming convention |
| examples/react/useGetIdTokenQuery/package.json | Rename package to follow "example-" prefix convention |
| examples/react/react-data-connect/package.json | Rename package to follow "example-" prefix convention |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request aims to fix the changesets configuration to properly ignore example packages. The change from a file-path-based ignore pattern (examples/**) to a package-name-based one (example-*) is correct. The renaming of the React example packages to align with this new pattern is also a good step. I've added one comment regarding the scope of this change to ensure all example packages are handled consistently.
No description provided.