🚧 Provide a Resource API Helper and example for testing Application Insights#61
Conversation
paul-warwick-cdt
requested review from
stijnmoreels and
tomkerkhove
as code owners
| /// <summary> | ||
| /// Authentication representation to authenticate with resources running on Azure. | ||
| /// </summary> | ||
| public class ResourceApiAuthentication |
There was a problem hiding this comment.
Can't we refactor our existing authentication and use that?
There was a problem hiding this comment.
Yes the token output of the Logic Apps is the same.
There was a problem hiding this comment.
Yes that is correct, but I think we should be able to re-use the authentication since it's the same, no?
There was a problem hiding this comment.
Yes a refactor of the Authenticator to give it generic naming and decouple from being Logic App specific would allow this PR to be re-factored and retested. Will proceed on that basis.
tomkerkhove
changed the title
|
I was under the impression #60 is about Application Insights but it's mainly talking about Resource API. What should I understand with that? What does it represent? Is this the foundation for Application Insights features? If so, maybe better to add those in the same PR? |
|
Oh and thanks for the PR! |
tomkerkhove
changed the title
|
Any update on this? |
|
I'll check on the naming refactor away from core components being named for Logic Apps (as per 15 Sep) , and if this is completed, I'll re-align this code. |
2 participants
Relates to #60