Skip to content

Closing connections on EngineIO._close() #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcawlfield wants to merge 1 commit into
base: 0.7.1
Choose a base branch
from
Open

Closing connections on EngineIO._close() #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions socketIO_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,15 @@ def _close(self):
except AttributeError:
pass
if not hasattr(self, '_opened') or not self._opened:
self._http_session.close()
return
engineIO_packet_type = 1
try:
self._transport_instance.send_packet(engineIO_packet_type)
except (TimeoutError, ConnectionError):
pass
self._http_session.close()
self._transport_instance.close()
self._opened = False

def _ping(self, engineIO_packet_data=''):
Expand Down
6 changes: 6 additions & 0 deletions socketIO_client/transports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ def send_packet(self, engineIO_packet_type, engineIO_packet_data=''):
def set_timeout(self, seconds=None):
pass

def close(self):
pass


class XHR_PollingTransport(AbstractTransport):

Expand Down Expand Up @@ -168,6 +171,9 @@ def send_packet(self, engineIO_packet_type, engineIO_packet_data=''):
def set_timeout(self, seconds=None):
self._connection.settimeout(seconds or self._timeout)

def close(self):
self._connection.close()


def get_response(request, *args, **kw):
try:
Expand Down