Skip to content

Receiving messages (i.e. events with name 'message') now works properly. #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mellesies wants to merge 2 commits into
base: 0.8.0
Choose a base branch
from
Open

Receiving messages (i.e. events with name 'message') now works properly. #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac89424
Receiving messages (i.e. events with name 'message') now works properly.
mellesies Nov 4, 2018
55e8fd7
Stop trying to connect when receiving an http 401 (unauthorized).
mellesies Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion socketIO_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,12 @@ def _process_packet(self, packet):
except KeyError:
raise PacketError(
'unexpected engine.io packet type (%s)' % engineIO_packet_type)
delegate(engineIO_packet_data, namespace)
if engineIO_packet_type == 4:
return engineIO_packet_data

delegate(engineIO_packet_data, namespace)


def _on_open(self, data, namespace):
namespace._find_packet_callback('open')()
Expand Down
4 changes: 4 additions & 0 deletions socketIO_client/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@ class PacketError(SocketIOError):

class TimeoutError(SocketIOError):
pass


class AuthorizationError(SocketIOError):
pass
5 changes: 4 additions & 1 deletion socketIO_client/transports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
else:
from websocket._ssl_compat import SSLError

from .exceptions import ConnectionError, TimeoutError
from .exceptions import ConnectionError, TimeoutError, AuthorizationError
from .parsers import (
encode_engineIO_content, decode_engineIO_content,
format_packet_text, parse_packet_text)
Expand Down Expand Up @@ -183,7 +183,10 @@ def get_response(request, *args, **kw):
except requests.exceptions.SSLError as e:
raise ConnectionError('could not negotiate SSL (%s)' % e)
status_code = response.status_code

if 200 != status_code:
if status_code == 401:
raise AuthorizationError('unauthorized')
raise ConnectionError('unexpected status code (%s %s)' % (
status_code, response.text))
return response
Expand Down