Skip to content

Implement reading and setting default values#34

Open
duskybomb wants to merge 2 commits intomasterfrom
issue/28
Open

Implement reading and setting default values#34
duskybomb wants to merge 2 commits intomasterfrom
issue/28

Conversation

@duskybomb
Copy link
Copy Markdown

Reading and set default if value is not defined

  • What all fields can have _default?
  • Should I add as many fields as possible to fields.yml?

@m3nu
Copy link
Copy Markdown
Collaborator

m3nu commented Jul 3, 2018

Tests and actual default values?

@duskybomb
Copy link
Copy Markdown
Author

For tests, we need to resolve issue with _required fields (whether name and LineTotalAmount are required fields or not), because else is_valid() will always return False[1]. It is also affecting other features and tests as well.

@duskybomb
Copy link
Copy Markdown
Author

What all fields can have default values?

 - to check default values
Corrected test
 - write pdf
 - write xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants