feat(ui): (optional) Protect starred images from accidental deletion#8406
Closed
FloeHetling wants to merge 5 commits intoinvoke-ai:mainfrom
Closed
feat(ui): (optional) Protect starred images from accidental deletion#8406FloeHetling wants to merge 5 commits intoinvoke-ai:mainfrom
FloeHetling wants to merge 5 commits intoinvoke-ai:mainfrom
Conversation
- new settings option: "Protect starred images" - when protection is enabled, following features will be active: * there will be impossible to delete an image with star mark. If "Confirm on delete" is enabled, a warning toast will appear on said attempt (silent otherwise) * upon attempting to use "Delete Board and Images" option, additional confirmation will be issued if said board has at least one image with star mark * upon attempting to delete a group selected of images, images marked with Star will not be touched and a toast about protection status will be thrown if "Confirm on delete" is enabled (silent otherwise) * same behavior should be expected from "Delete All Uncategorized Images" option.
psychedelicious
suggested changes
Aug 11, 2025
Contributor
psychedelicious
left a comment
There was a problem hiding this comment.
Checking the RTK Query cache to determine if an image is starred will not work reliably. It is possible for starred images to not be in the cache, in which case the protection feature wouldn't work. They would be deleted.
I think this needs to be a backend feature to work properly. Image/board services and deletion endpoints could have a delete_starred: bool = True kwarg. It would make the change a lot simpler too.
Contributor
Author
|
closed due to feature is being completely re-done from scratch relying on latest changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / Discussions
Following this QoL plan from @hipsterusername (Discord message link)
QA Instructions
Careful. This test implies all of the images can or will be eventually lost. For safety of your artwork, consider using testing environment
Checklist
What's Newcopy (if doing a release after this PR)