Skip to content

fix(ui): respect direction of selection in Gallery#8458

Merged
psychedelicious merged 3 commits intoinvoke-ai:mainfrom
csehatt741:feat/selection-of-multiple-images
Aug 25, 2025
Merged

fix(ui): respect direction of selection in Gallery#8458
psychedelicious merged 3 commits intoinvoke-ai:mainfrom
csehatt741:feat/selection-of-multiple-images

Conversation

@csehatt741
Copy link
Contributor

Summary

A new bugfix was implemented to respect the direction of selection of multiple images in Gallery

  • buildOnClick was modified in GalleryImage.tsx to respect the direction of the selection

Related Issues / Discussions

Closes #8451

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Aug 22, 2025
Copy link
Contributor

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks multi-range selections.

Current behaviour:

  • Click image 1 -> [1]
  • Shift-click image 3 -> [1,2,3]
  • Cmd/Ctrl-click image 5 -> [1,2,3,5]
  • Shift-click image 7 -> [1,2,3,5,6,7]

This PR:

  • Click image 1 -> [1]
  • Shift-click image 3 -> [1,2,3]
  • Cmd/Ctrl-click image 5 -> [1,2,3,5]
  • Shift-click image 7 -> [5,6,7]

@csehatt741 csehatt741 force-pushed the feat/selection-of-multiple-images branch from 1464f1a to 3862694 Compare August 25, 2025 07:14
@csehatt741
Copy link
Contributor Author

This breaks multi-range selections.

Current behaviour:

  • Click image 1 -> [1]
  • Shift-click image 3 -> [1,2,3]
  • Cmd/Ctrl-click image 5 -> [1,2,3,5]
  • Shift-click image 7 -> [1,2,3,5,6,7]

This PR:

  • Click image 1 -> [1]
  • Shift-click image 3 -> [1,2,3]
  • Cmd/Ctrl-click image 5 -> [1,2,3,5]
  • Shift-click image 7 -> [5,6,7]

Fixed

Copy link
Contributor

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psychedelicious psychedelicious merged commit c7fb8f6 into invoke-ai:main Aug 25, 2025
13 checks passed
@csehatt741 csehatt741 deleted the feat/selection-of-multiple-images branch August 25, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Minor bug, selection of multiple images in Gallery

2 participants